Reviewing hg-review

 

397: Merged in benallard/hg-review (pull request #1) by Steve Losh

Merged in benallard/hg-review (pull request #1)

No changeset-level comments yet…

Add a comment on this changeset
Post Comment Cancel

Signoffs

No signoffs yet…

Files

cmV2aWV3L3dlYi5weQ==

review/web.py

Add a comment on this file
Post Comment Cancel
… skipped 45 lines …
45
46 def _cset_gravatar(cset, size=30):
47 return 'http://www.gravatar.com/avatar/%s?s=%d' % (md5(email(cset.user())).hexdigest(), size)
48
49 def _line_type(line):
50 - return 'rem' if line[0] == '-' else 'add' if line[0] == '+' else 'con'
51 + try:
52 + return {'+': 'add', '-':'rem'}[line[0]]
53 + except (IndexError, KeyError):
54 + return 'con'
55
56 def _categorize_signoffs(signoffs):
57 return { 'yes': len(filter(lambda s: s.opinion == 'yes', signoffs)),
58 'no': len(filter(lambda s: s.opinion == 'no', signoffs)),
59 'neutral': len(filter(lambda s: s.opinion == '', signoffs)),}
… skipped 194 lines …